This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($http): allow empty json response #9562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a response contains an `application/json` header and the response is empty the response should be left as is. Fixes angular#9532
| @@ -771,7 +771,7 @@ function $HttpProvider() { | |||
| function transformResponse(response) { | |||
| // make a copy since the response must be cacheable | |||
| var resp = extend({}, response); | |||
| if(config.method === 'HEAD'){ | |||
| if (!response.data) { | |||
There was a problem hiding this comment.
Should we maybe special case 204 and HEAD, and just set the value to undefined instead?
if (!response.data && (config.method === 'HEAD' || response.status === 204)) {
delete resp.data; // or resp.data = undefined;
}Because really, an empty JSON string is a programming error in other cases.
Up to you guys though
There was a problem hiding this comment.
@IgorMinar What do you think?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a response contains an
application/jsonheader andthe response is empty the response should be left as is.
Fixes #9532