This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($browser): account for IE deserializing history.state on each read #9587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
added a commit
to mgol/angular.js
that referenced
this pull request
Oct 13, 2014
IE 10-11+ deserialize history.state on every read, causing simple comparisons against history.state always return false. Account for that caching `history.state` on every hashchange or popstate event. Also, prevent firing onUrlChange callbacks twice if both popstate and hashchange event were fired. Closes angular#9587 Refs angular#9545
mgol
added a commit
to mgol/angular.js
that referenced
this pull request
Oct 13, 2014
IE 10-11+ deserialize history.state on every read, causing simple comparisons against history.state always return false. Account for that caching `history.state` on every hashchange or popstate event. Also, prevent firing onUrlChange callbacks twice if both popstate and hashchange event were fired. Closes angular#9587 Refs angular#9545
mgol
added a commit
to mgol/angular.js
that referenced
this pull request
Oct 13, 2014
IE 10-11+ deserialize history.state on every read, causing simple comparisons against history.state always return false. Account for that caching `history.state` on every hashchange or popstate event. Also, prevent firing onUrlChange callbacks twice if both popstate and hashchange event were fired. Closes angular#9587 Refs angular#9545
|
This PR in its current form fixes the inifinite digest in IE issue but makes the problem reported in #9545 (comment) even worse; investigating. EDIT: the issue is now resolved. |
mgol
added a commit
to mgol/angular.js
that referenced
this pull request
Oct 13, 2014
IE 10-11+ deserialize history.state on every read, causing simple comparisons against history.state always return false. Account for that caching `history.state` on every hashchange or popstate event. Also: 1. Prevent firing onUrlChange callbacks twice if both popstate and hashchange event were fired. 2. Fix the issue of routes sometimes not firing the URL change in all browsers. Closes angular#9587 Fixes angular#9545
|
I still need to think how to write the test for the specific issue described in #9545. |
IE 10-11+ deserialize history.state on every read, causing simple comparisons against history.state always return false. Account for that caching `history.state` on every hashchange or popstate event. Also: 1. Prevent firing onUrlChange callbacks twice if both popstate and hashchange event were fired. 2. Fix the issue of routes sometimes not firing the URL change in all browsers. Closes angular#9587 Fixes angular#9545
mgol
added a commit
to mgol/angular.js
that referenced
this pull request
Oct 13, 2014
Check that pushState is not invoked if $browser.url() and $browser.state() is passed to $browser.url setter. Also, a minor refactor in $browser.url code and $browser specs. Refs angular#9587
mgol
added a commit
to mgol/angular.js
that referenced
this pull request
Oct 13, 2014
Check that pushState is not invoked if $browser.url() and $browser.state() is passed to $browser.url setter. Also, a minor refactor in $browser.url code and $browser specs. Refs angular#9587
mgol
added a commit
that referenced
this pull request
Oct 13, 2014
Check that pushState is not invoked if $browser.url() and $browser.state() is passed to $browser.url setter. Also, a minor refactor in $browser.url code and $browser specs. Refs #9587
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix($browser): account for IE deserializing history.state on each read
IE 10-11+ deserialize history.state on every read, causing simple comparisons
against history.state always return false. Account for that caching
history.stateon every hashchange or popstate event.Also:
event were fired.
Closes #9587
Fixes #9545