Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update CONTRIBUTING.md #9608

Closed
wants to merge 1 commit into from
Closed

Conversation

afshinator
Copy link
Contributor

docs: correction

There is no prototypical inheritance, the correct word is 'prototypal'.

docs: correction

There is no prototypical inheritance, the word is 'prototypal'.
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@afshinator afshinator closed this Oct 14, 2014
petebacondarwin pushed a commit that referenced this pull request Oct 14, 2014
@petebacondarwin
Copy link
Contributor

Thanks @afshinator. While we are being pedantic, can you follow our commit message guidelines for future pull requests please? It saves us time not having to rework the messages when merging

@afshinator
Copy link
Contributor Author

I thought I was! Whats missing from the below ?
docs: correction

There is no prototypical inheritance, the correct word is 'prototypal'.

@gkalpak
Copy link
Member

gkalpak commented Oct 14, 2014

@afshinator
You commit message was:

Update CONTRIBUTING.md
docs: correction

There is no prototypical inheritance, the word is 'prototypal'.

While is should be something like:

docs(CONTRIBUTING): prototypical -> prototypal

<Describe your change here> e.g.:
There is no prototypical inheritance, the word is 'prototypal'.

I still don't know why I get into other people's business...

petebacondarwin pushed a commit that referenced this pull request Oct 14, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants