Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(loader): fix double spaces #9630

Closed
wants to merge 1 commit into from

Conversation

kwypchlo
Copy link
Contributor

Fix double spaces in return statement. Double spaces between return and
returned value brake minification process of some minifiers (bug found on JSMin
https://github.com/mrclay/jsmin-php).

Fix double spaces in return statement. Double spaces between return and
returned value brake minification process of some minifiers (bug found on JSMin
https://github.com/mrclay/jsmin-php).
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@kwypchlo
Copy link
Contributor Author

@mary-poppins I have signed CLA before submitting this PR (Oct 15, 2014 00:52 PDT). My github username email match the email in CLA as well.

@lgalfaso
Copy link
Contributor

@kwypchlo does the email in the commit match the email in the CLA?

@kwypchlo
Copy link
Contributor Author

@lgalfaso yes it does

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@IgorMinar
Copy link
Contributor

thanks

@IgorMinar IgorMinar closed this in 8b2f1a4 Oct 17, 2014
@hzoo
Copy link
Contributor

hzoo commented Oct 20, 2014

We shouldn't have any more of these since the requireSpaceAfterKeywords: true rule is added in

@kwypchlo kwypchlo deleted the fix-double-space branch October 22, 2014 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants