This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor(Angular) Use Object.keys instead of manually constructing an array. #9704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Object.keys has a specific sort order which is a bit different from the one used previously. So this results in a bit of a functional change, but I'm not sure if it would ball anybody |
|
Since the result is sorted using Array.prototype.sort before it's returned, that doesn't make a difference, does it? |
|
Oh I thought you removed the sort. Reading code on a phone is hard :) should be ok then |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No performance degradation: http://jsperf.com/get-all-keys-from-object