Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor(*): removing unused vars #9710

Closed
wants to merge 1 commit into from

Conversation

jbedard
Copy link
Collaborator

@jbedard jbedard commented Oct 21, 2014

No description provided.

@rodyhaddad
Copy link
Contributor

I tried making js-hint do this manually so grunt ci-checks pick these up in the future, but didn't have much luck (jshint was warning about things like $InterpolateProvider never being used, even when run against build/angular.js)

So I merged this in for now, but it would be nice to have this task automated (and ported to 1.2.x)

@caitp
Copy link
Contributor

caitp commented Oct 21, 2014

I thought I said "lgtm" from my phone a while ago, guess not =) good stuff @jbedard

@jbedard
Copy link
Collaborator Author

jbedard commented Oct 22, 2014

After finding one of these I added the jshint option and found a bunch more, but I could have missed more between all the $interpolateProvider and similar, and I only ran jshint:ng. I took a quick look and couldn't find any easy way to allow some globals as exports such as $interpolateProvider while still catching others. The only thing I can think of is adding /* jshint unused:false */ all over the place...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants