Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

style(filterSpec): fix white-space and newline inconsistencies #9765

Closed

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Oct 23, 2014

No description provided.

@@ -91,7 +89,6 @@ describe('Filter: filter', function() {
]);
});


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're still removing newlines rather than adding them

@gkalpak gkalpak force-pushed the filterSpec-whitespace-newlines branch from 253cf07 to 6677ceb Compare October 23, 2014 21:14
@caitp
Copy link
Contributor

caitp commented Oct 23, 2014

LGTM --- but I think there's an IE bug in master right now, I might need to revert something before landing this. Do you have an IE browser you could test with @gkalpak?

@gkalpak
Copy link
Member Author

gkalpak commented Oct 23, 2014

@caitp: Running the unit tests against IE9-11:
IE10, IE11: All pass
IE9: 62/3532 fail

@caitp
Copy link
Contributor

caitp commented Oct 23, 2014

Damn, I think it was the svg/ngSanitize fix. Can you try with the sha before it? If it's working I'll revert and try to fix it

@gkalpak gkalpak force-pushed the filterSpec-whitespace-newlines branch from 6677ceb to 0cc2760 Compare October 23, 2014 23:17
@gkalpak
Copy link
Member Author

gkalpak commented Oct 23, 2014

@caitp: I tried with the commit before the SVG/ngSanitize fix and I still get the errors (on IE).
There is a good chance I am doing something wrong though, because I even get errors with v1.3.0 !?

Hm...running the 1.3.0 tests against IE9 throws a few errors.
Something about not being able to call call() on undefined or null in src/ngScenario/Application.js:54 (which might be a result of calling Application's navigateTo() without a loadFn).
I don't even know what Application is for, but there seem to be a lot of places where navigateTo() is called without a loadFn and other browsers don't complain about that !

Yeah, I've probably messed something up locally...

@gkalpak gkalpak force-pushed the filterSpec-whitespace-newlines branch from 0cc2760 to e9f6a36 Compare October 24, 2014 06:27
@caitp
Copy link
Contributor

caitp commented Oct 24, 2014

neh I think it was just SL being broken, tree is green --- no need to revert nothin :>

@caitp
Copy link
Contributor

caitp commented Oct 24, 2014

merged~

@caitp caitp closed this in 7574dd2 Oct 24, 2014
@gkalpak gkalpak deleted the filterSpec-whitespace-newlines branch October 25, 2014 04:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants