This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test(ngSanitize): enhance test regarding the xlink:href attribute
#9770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase this, it should pass now i think |
|
(I guess you had the idea from my comment on the other PR before I did :p) |
| @@ -246,6 +246,15 @@ describe('HTML', function() { | |||
| it('should sanitize SVG xmlns:xlink attribute values', function() { | |||
| expectHTML('<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><a xmlns:xhref="javascript:alert()"></a></svg>') | |||
There was a problem hiding this comment.
This test doesn't really fit into this test case. We should either leave it out, or move it to a test case named accordingly.
christianliebel
pushed a commit
to christianliebel/angular.js
that referenced
this pull request
Oct 25, 2014
SVG attribute test splitted, descriptions changed accordingly Related to angular#9770
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Related to #9751 (comment) .)