This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(jenkins): reset baseUrl in protractor conf #9816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caitp mind taking a look? |
Commit 22b817e changed the url used by protractor in all docs tests to prepend "build/docs", which was already set to the `baseUrl` in `protractor-jenkins.conf`. This commit just changes the protractor config's `baseUrl` to adapt to the changes in the spec files. Closes angular#9783
|
Yeah looking |
|
So jenkins was just using the wrong base? |
|
Yep. Well, the base became wrong after the path in all the tests changed. On Tue Oct 28 2014 at 1:35:33 PM Caitlin Potter notifications@github.com
|
|
So your build isn't running on jenkins right now, but the fix looks right to me --- I'm just not sure if there's more problems following that |
|
I manually ran |
|
lgtm |
|
Thanks! Merged: b4db713 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Tested before and after fix locally and manually on ci.angularjs.org)
Commit 22b817e changed the url
used by protractor in all docs tests to add build/docs, which
was already set to the baseUrl in protractor-jenkins.conf. This
commit just changes the protractor config's baseUrl to adapt
to the changes in the spec files.
Closes #9783