Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update q.js #9817

Closed
wants to merge 1 commit into from
Closed

Update q.js #9817

wants to merge 1 commit into from

Conversation

mcjffld
Copy link

@mcjffld mcjffld commented Oct 28, 2014

added IE8 warning to promise.catch()

added IE8 warning to promise.catch()
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@Narretz
Copy link
Contributor

Narretz commented Oct 29, 2014

It's not particularly useful to add the note about IE8 to the master branch, as IE8 is not supported anymore. I think that would be misleading.

@gkalpak
Copy link
Member

gkalpak commented Oct 29, 2014

We had a discussion about it in #9815 (comment).

Recapping:
There is a similar notice about IE8 for finally() a couple of lines below.
I suggest we remove the IE8 specific notice from 1.3.x and add a similar notice for catch() in 1.2.x.

@Narretz: WDYT ?

@pkozlowski-opensource
Copy link
Member

@gkalpak - your proposal sounds sensible - let's remove all those IE8-related warnings from 1.3 and we can add a notice to 1.2.

Going to close this PR, @gkalpak @mcjffld fancy another PR that does the above? Thnx!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants