Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/Forms): clarify ngModel behavior for validation #9866

Closed
wants to merge 1 commit into from

Conversation

hzoo
Copy link
Contributor

@hzoo hzoo commented Oct 31, 2014

For #9861

@@ -56,6 +56,9 @@ for other directives to augment its behavior.

Note that `novalidate` is used to disable browser's native form validation.

The value of `ngModel` won't be set unless it passes validation for the input field.
For example: inputs of type `email` must have the form `x@y`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe must have a value in the form "user@domain"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea makes more sense

@caitp caitp added this to the 1.3.x milestone Oct 31, 2014
@hzoo
Copy link
Contributor Author

hzoo commented Oct 31, 2014

Ok changed the wording. Also is there a way to edit the last commit using github's web interface? I've been doing a rebase and then push -f.

@caitp
Copy link
Contributor

caitp commented Oct 31, 2014

nah, the web interface sucks :(

@caitp
Copy link
Contributor

caitp commented Oct 31, 2014

anyways looks good to me

@caitp caitp closed this in 2a2fd14 Oct 31, 2014
@hzoo hzoo deleted the patch-1 branch November 1, 2014 02:06
@@ -56,6 +56,9 @@ for other directives to augment its behavior.

Note that `novalidate` is used to disable browser's native form validation.

The value of `ngModel` won't be set unless it passes validation for the input field.
For example: inputs of type `email` must have a value in the form of `user@domain`.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good idea to mention that this default behaviour can be overriden via ngModelOptions' allowInvalid.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants