This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(ngModel.NgModelController): use $evalAsync instead of $apply for events #9891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for event handling Have the apply called safely during events by using `$evalAsync` rather than `$apply` This will help ensure that an apply for a user directive is not called during a digest cycle.
|
@Narretz and @gkalpak this is the doc update as discussed in #9808. I thought about checking the type of event for some events only but I didn't want to overcomplicate the example. However, if you think it's better to add a check for the blur (or any other events?) in the example please let me know and I'll update and retest. |
alexanderchan
changed the title
|
LGTM (for what it's worth 😄) |
|
eh, alright |
caitp
pushed a commit
that referenced
this pull request
Nov 11, 2014
…for event handling Have the apply called safely during events by using `$evalAsync` rather than `$apply` This will help ensure that an apply for a user directive is not called during a digest cycle. Closes #9891
|
@caitp, cool. I know it looks a bit trivial but I've seen it happen in the wild. Some issues on a few people's directives that use alternatives such as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the apply called safely during events by using
$evalAsyncrather than$apply.This will help ensure that an apply for a user directive is not called during a digest cycle.