Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/Conceptual Overview): change "a" to "an" before ng-controller #9895

Closed
wants to merge 1 commit into from

Conversation

rsperberg
Copy link
Contributor

The article matches how a word is pronounced. Since "en-gee"-controller begins with a vowel, the article used should be "an" and not "a": we added an ng-controller

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@rsperberg
Copy link
Contributor Author

I checked and the page at
https://cla.developers.google.com/clas/edit?id=572375359658&kind=KIND_INDIVIDUAL&domain=DOMAIN_GOOGLE
showed that I signed the CLA earlier today, Nov 03, 2014 15:02 PST

​Thanks!

Roger

On Mon, Nov 3, 2014 at 7:10 PM, Mary Poppins notifications@github.com
wrote:

I'm sorry, but I wasn't able to verify your Contributor License Agreement
(CLA) signature. CLA signature is required for any code contributions to
AngularJS.

Please sign our CLA
https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#signing-the-cla
and ensure that the CLA signature email address and the email address in
this PR's commits match
.

If you signed the CLA as a corporation, please let us know the company's
name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses
don't match. Please sign the CLA again or update the email address in the
commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA
verification process.


Reply to this email directly or view it on GitHub
#9895 (comment).

Roger SperbergMontclair, NJ 07043

973-200-4224-- rsperberg at gmail
@RogerSPress
github.com/rsperberg http://github.com/rsperberg
linkedin.com/in/rsperberg http://linkedin.com/in/rsperberg

web development track at

@pkozlowski-opensource
Copy link
Member

This sounds strange to me but I'm not a native speaker so... @petebacondarwin ?

@caitp
Copy link
Contributor

caitp commented Nov 10, 2014

it sounds better to have "an n-" than "a n-", so this looks right to me

@petebacondarwin
Copy link
Contributor

I agree with @caitp. Feel free to merge.

pkozlowski-opensource pushed a commit to pkozlowski-opensource/angular.js that referenced this pull request Nov 10, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants