This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($location): don't rewrite when link is shift-clicked #9906
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1471,6 +1471,19 @@ describe('$location', function() { | |||
| }); | |||
|
|
|||
|
|
|||
| it('should not rewrite when clicked with shift pressed', function() { | |||
| configureService({linkHref: 'base/a?b=c', html5Mode: true, supportHist: true}); | |||
There was a problem hiding this comment.
ping @tbosch --- the other tests in this suite don't seem to be quite right. In testing, even without this fix, if linkHref was not preceded with base/, we would not rewrite anyways because we would determine the link to not be within the app url. So I think something is a bit wrong with these tests.
However, with the test written like this, without the fix we fail and with we pass.
|
@caitp Please ask @petebacondarwin to review. Really busy... |
|
3 months later, bitrotten patch, and no comment from assigned reiewer. @petebacondarwin were you going to do this? it's a one liner |
|
:-) - I'll look over the weekend. |
petebacondarwin
added a commit
that referenced
this pull request
Jan 25, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9904