This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($http): won't parse single space response #9907
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this question, Rails in order to patch a bug in Safari, returns a single space when calling
head :ok, which is the standard for POST requests.Angular since 9ba24c54d checks if the body is empty before calling JSON parse, but this still breaks in this case, since the body isn't empty, but contains a single space.
We are hitting this issue when trying to upgrade from Angular 1.2.10. This PR should help in that case.