Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(select): use strict comparison for isSelected with selectAs #9949

Closed
wants to merge 1 commit into from
Closed

fix(select): use strict comparison for isSelected with selectAs #9949

wants to merge 1 commit into from

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Nov 6, 2014

Fixes #9639

@Narretz Narretz mentioned this pull request Nov 6, 2014
Closed
@petebacondarwin
Copy link
Contributor

That's too easy!! Surely it is more complcated than that? :-)

@Narretz
Copy link
Contributor Author

Narretz commented Nov 6, 2014

The comparison was strict before the refactoring, soo, yeah that should be it.

Although it also affects ngOption expressions of type c.value for c in p.choices, but onyl if they don't have a null value. I can add a test for that tomorrow.

@IgorMinar
Copy link
Contributor

lgtm

@Narretz Narretz closed this in 9e30594 Nov 7, 2014
@Siyfion Siyfion mentioned this pull request Nov 20, 2014
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes component: forms type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ngOption model value 0 or false treated as 'not selected' after 1.3.0-rc.4
5 participants
@Narretz @petebacondarwin @IgorMinar @caitp @mary-poppins