Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(nav): Highlight current nav-index-listing #9974

Closed
wants to merge 2 commits into from
Closed

docs(nav): Highlight current nav-index-listing #9974

wants to merge 2 commits into from

Conversation

kentcdodds
Copy link

Color the current nav-index-listing item dark red to make it easier to know where you are.

Closes #9970

Color the current nav-index-listing item dark red to make it easier to know where you are.

Closes #9970
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@pkozlowski-opensource
Copy link
Member

@kentcdodds thnx for the PR. At present it seems to be breaking some e2e tests - at the beginning I thought it was Travis flake but after restarting the job a couple of times it looks like a legitimate bug. Could you please have a look? https://travis-ci.org/angular/angular.js/jobs/40415397

@kentcdodds
Copy link
Author

Looking into it now. This is why we love Travis 👍

@kentcdodds
Copy link
Author

Looks like that fixed it @pkozlowski-opensource :-)

@pkozlowski-opensource
Copy link
Member

LGTM, merging

@pkozlowski-opensource
Copy link
Member

Hmm, I'm just wondering what the active class is used for? It seems to be added to all the links but doesn't seem to be defined anywhere in the CSS. On top of this the condition for the "active" class looks similar to the "current" check.

I'm going to merge this one as the proposed highlighting is definitively a good thing, but it would be cool to clean-up stuff if we can.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(indexPage.template.html): Highlight current navItem
3 participants