Updated IE8 warning about q.js on 1.2 #9987
Conversation
added IE8 warning to promise.catch()
|
lgtm --- this was suggested by @pkozlowski-opensource right? (I know I saw a mention of adding these docs in v1.2.x in my bugmail this morning, but I can't remember who said it). |
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
yes -- warning only makes sense on the code that supports IE8 |
|
just double checked, my email on the CLA matches the github email -- not sure why it is getting flagged. |
|
the robot is broken --- don't worry about it |
|
@mcjffld it seems like jscs is upset about something: https://travis-ci.org/angular/angular.js/jobs/40575725 |
|
when isn't jscs upset about something ^_^ but yeah, we can remove that trailing whitespace while merging, no big deal. I'll merge in a few minutes |
added IE8 warning to promise.catch() Closes #9987
|
Closed by c50a047 |
|
oh god did I forget to change the commit mssage? |
|
Closed again by d87b791 |
added IE8 warning to promise.catch()