fix(migrations): count used dependencies inside existing control flow (…

…#59861)

Fixes that the control flow migration wasn't checking the content of pre-existing control flow nodes for dependencies.

Fixes #59846.

PR Close #59861

packages/core/schematics/ng-generate/control-flow-migration/types.ts

@@ -390,6 +390,7 @@ export class CommonCollector extends RecursiveVisitor {
         this.count++;
       }
     }
+    super.visitBlock(ast, null);
   }
 
   override visitText(ast: Text) {

packages/core/schematics/test/control_flow_migration_spec.ts

@@ -6479,6 +6479,39 @@ describe('control flow migration', () => {
 
       expect(actual).toBe(expected);
     });
+
+    it('should not remove common module if symbols are used inside new control flow', async () => {
+      writeFile(
+        '/comp.ts',
+        [
+          `import {CommonModule} from '@angular/common';`,
+          `import {Component} from '@angular/core';\n`,
+          `@Component({`,
+          `  imports: [CommonModule],`,
+          `  template: \`@if (toggle) {<div>{{ d | date }}</div>} <span *ngIf="toggle">hi</span>\``,
+          `})`,
+          `class Comp {`,
+          `  toggle = false;`,
+          `}`,
+        ].join('\n'),
+      );
+
+      await runMigration();
+      const actual = tree.readContent('/comp.ts');
+      const expected = [
+        `import {CommonModule} from '@angular/common';`,
+        `import {Component} from '@angular/core';\n`,
+        `@Component({`,
+        `  imports: [CommonModule],`,
+        `  template: \`@if (toggle) {<div>{{ d | date }}</div>} @if (toggle) {<span>hi</span>}\``,
+        `})`,
+        `class Comp {`,
+        `  toggle = false;`,
+        `}`,
+      ].join('\n');
+
+      expect(actual).toBe(expected);
+    });
   });
 
   describe('no migration needed', () => {