Components with the same name (via alias) results in ngfactory with duplicate function implementations

[jelbourn]

Steps to reproduce

• Clone https://github.com/jelbourn/material2/tree/importas-repro
• npm i
• Run gulp e2e

After this runs once, you can re-run ngc as:

./node_modules/.bin/ngc -p ./dist/packages/e2e-app/tsconfig-build.json

(gulp e2e will build all of the dependencies as well)

Expected

The e2e app compiles successfully (as with Angular 4)

Actual

ngc emits an error

e2e-app-module.ngfactory.ts(451,10): error TS2393: Duplicate function implementation.
e2e-app-module.ngfactory.ts(454,10): error TS2393: Duplicate function implementation.
e2e-app-module.ngfactory.ts(458,10): error TS2393: Duplicate function implementation.
e2e-app-module.ngfactory.ts(461,10): error TS2393: Duplicate function implementation.

The file e2e-app-module.ngfactory.ts is not written to the file system.

Commentary

E2eAppModule declares (and marks as entryComponents) two classes both called TestDialog. In the module file, they are imported like:

import {TestDialog} from './dialog/dialog-e2e';
import {TestDialog as TestDialogFullScreen} from './fullscreen/fullscreen-e2e';

Renaming one of them resolves the error.

cc @tbosch @chuckjaz @crisbeto

[tbosch]

This seems to be related to having noEmitOnError = false in the tsconfig.json. If I remove it, everything is fine. Will create a PR to fix this.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}