ApplicationRef's onDestroy method should not be internal

[edusperoni]

Which @angular/* package(s) are relevant/related to the feature request?

core

Description

When developing with NgModules we were able to do:

const moduleRef = await platformBrowserDynamic().bootstrapModule(AppModule);
moduleRef.onDestroy(() => { /* some logic */ });

The new bootstrapApplication now returns a ApplicationRef. Although the onDestroy method exists in ApplicationRef, it's marked as internal and not exposed.

Proposed solution

Make ApplicationRef.onDestroy not internal and part of the public API. This makes sense as well because .destroy() and .destroyed are part of the public API.

Alternatives considered

(applicationRef as any).onDestroy(() => {});

or getting the reference to the first component and using its onDestroy.

[JeanMeche]

FYI, making onDestroy public has been discussed as part of #45624.

@AndrewKushnir wasn't opposed to making it public if a use case arises !

[angular-robot]

This feature request is now candidate for our backlog! In the next phase, the community has 60 days to upvote. If the request receives more than 20 upvotes, we'll move it to our consideration list.

You can find more details about the feature request process in our documentation.

[edusperoni]

@AndrewKushnir if you're fine with it, I can do the PR to expose it. We use it in NativeScript to manage the Angular bootstrap and application launch/exit events.

[AndrewKushnir]

@edusperoni yes, that makes sense, feel free to open a PR 👍

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}