[beta.2] ngDoCheck is not a function when using minified bundles

[ericmartinezr]

When using minified bundles with SystemJS, and a simple snippet like this

        <template ngFor #item [ngForOf]="items" #i="index">
          <li>{{i}}</li>
          <li *ngIf="i % 2 == 0">number is even</li>
        </template>

Will throw

TypeError: this.directive_0_0.ngDoCheck is not a function

This is only reproducible with minified bundles, non-minified work correctly.

As an example check this plnkr (took it from #6304 (comment)). To reproduce switch between minified and unminified bundles.

This is also reproducible with Webpack using this line in the config

    plugins : [
        new webpack.optimize.UglifyJsPlugin()
    ],

Am I missing something?

[ocombe]

I have a similar error on my ng2-webpack starter: preboot/angular-webpack#7
The message is No provider for t! (t -> t) and adding mangle: false to the UglifyJS plugin fixes the problem (but the files are much bigger, so that's only temporary).

[ericmartinezr]

Hey @ocombe thanks for the tip. Lets wait then, thanks 👍

[ericmartinezr]

Beta.2 still have these issues with minifications, here's the plnkr updated http://plnkr.co/edit/24fjnjNdAvpbfY8a85B2?p=preview . Reproducible in the same way as in the first comment.

[alexeagle]

Marked P1 as lots of users are running into this

[ffMathy]

It is still present in beta 5.

[ffMathy]

Does P1 mean it will be fixed in the next beta?

[0x-r4bbit]

@ffMathy It means that it has a very high priority to be fixed. Doesn't guarantee that'll land in next beta release.

[ffMathy]

Still, it is a low effort one-hour task wih a P1 tag. I'm hoping for the best. I am stuck on my project until this is complete.

[ffMathy]

Still present in beta 6 as well.

[weupagency]

@ffMathy +1

[zuozuo]

@pxwise thanks!. @hongbo-miao @pxwise has given a much better solution.

[tbosch]

Might take a little while to land my PR...
On Wed, Mar 30, 2016 at 8:04 PM 左永辉 notifications@github.com wrote:

@pxwise https://github.com/pxwise thanks!. @hongbo-miao
https://github.com/Hongbo-Miao @pxwise https://github.com/pxwise has
given a much better solution.

—
You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#6380 (comment)

[ericmartinezr]

@tbosch thanks for taking a look at this.

In the meantime this workaround from @gdi2290 (see #6695 (comment)) works perfectly with minification.

Copy & pasting

mangle: {
  screw_ie8 : true,
  keep_fnames: true
}

[ericmartinezr]

For those following this issue, this is already fixed in latest master, here's the plnkr updated with the minified bundle from latest master http://plnkr.co/edit/3Bcdnef5C45tzOPSw5DE?p=preview

Can't wait to this to land 😄 👏

[ericmartinezr]

Ok people, to everyone following it's time to test this. The plnkr using b.16 works perfectly http://plnkr.co/edit/7TdYjVkbbvsy2AoLQcpf?p=preview , but there was a PR to disable mangle for bundles. So we should test in our local envs to see if minification actually works

This is my current config for UglifyJS plugin with webpack

        new webpack.optimize.UglifyJsPlugin({
            compress : {
                warnings : false
            }
        })

Can you guys try if it works for you with minification and without mangle? It works for me :D !

[micaelmbagira]

I did and it works for me as well.

[brechtbilliet]

Works like a charm!

[antonybudianto]

Finally it works!

[HerringtonDarkholme]

Tested locally.
Every thing works like a charm with both compress and mangle options turned on for uglifyjs. Further more keep-fname is turned off as well.
Both angular source and my application source are compression-safe.

Great works! @tbosch !

I wonder when we can turn the mangle and keep-fname off? @gdi2290 ?

[ericmartinezr]

This was fixed already, closing.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}