Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support metadata reflection for native class types #22356

Closed
wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Feb 21, 2018

closes #21731

supersedes #22315 (rebased version).

Original PR has all required approval for merging.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@vicb vicb added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Feb 21, 2018
@ngbot
Copy link

ngbot bot commented Feb 21, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required labels: "PR target: *", "cla: yes"
    failure forbidden label detected: cla: no
    failure status "cla/google" is failing
    pending status "code-review/pullapprove" is pending
    pending status "ci/circleci: lint" is pending
    pending status "ci/circleci: build" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mary-poppins
Copy link

You can preview d7f7583 at https://pr22356-d7f7583.ngbuilds.io/.

@vicb vicb added the target: patch This PR is targeted for the next patch release label Feb 22, 2018
@mary-poppins
Copy link

You can preview ee11579 at https://pr22356-ee11579.ngbuilds.io/.

@vicb vicb added cla: yes and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note cla: no labels Feb 22, 2018
@vicb vicb closed this in 5c89d6b Feb 22, 2018
vicb added a commit that referenced this pull request Feb 22, 2018
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018
smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018
smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018
@vicb vicb deleted the gh-22315 branch March 6, 2018 22:25
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@trotyl
Copy link
Contributor

trotyl commented May 9, 2018

Just got that base class doesn't have to be an IdentifierName but whatever expression, for example a webpack dev build would generate:

class Derived extends _some__WEBPACK_IMPORTED_MODULE_1__["Base"] {
    constructor() {
        super(...arguments);
    }
}

And this won't work then. But should be OK for production in favor of scope hoisting.

Seems this check should be deprecated as per #22642 comes, I'm not sure whether it should be fixed.

devversion added a commit to devversion/material2 that referenced this pull request Aug 20, 2018
Fixes that the table does not render properly when used inside of a ES2015 application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class.

* angular/angular#22642
* angular/tsickle#760

Fixes angular#9329
devversion added a commit to devversion/material2 that referenced this pull request Aug 20, 2018
Fixes that some components does not render properly when used inside of a ES2015 JIT application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class.

* angular/angular#22642
* angular/tsickle#760

See the more detailed issue here: angular#12760

Fixes angular#9329.
jelbourn pushed a commit to angular/components that referenced this pull request Aug 21, 2018
Fixes that some components does not render properly when used inside of a ES2015 JIT application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class.

* angular/angular#22642
* angular/tsickle#760

See the more detailed issue here: #12760

Fixes #9329.
jelbourn pushed a commit to angular/components that referenced this pull request Aug 29, 2018
Fixes that some components does not render properly when used inside of a ES2015 JIT application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class.

* angular/angular#22642
* angular/tsickle#760

See the more detailed issue here: #12760

Fixes #9329.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extended components do not receive constructor arguments when targetting ES6
4 participants