build(bazel): remove workaround no longer needed for module names for ngfactory & ngsummary files #25604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
added
the
target: patch
|
You can preview 81998de at https://pr25604-81998de.ngbuilds.io/. |
alexeagle
approved these changes
Aug 21, 2018
|
For reference: the workaround was added in #25335 |
alxhub
requested changes
Aug 21, 2018
There was a problem hiding this comment.
This change looks good to me!
The only thing I would ask is that you please add a commit description which details exactly what the workaround was for, and what changed which caused it to no longer be necessary. I'd be happy to approve this PR with that minor change :)
… ngfactory & ngsummary files Workaround was added in #25335. It was necessary for .ngfactory & .ngsummary files to have proper AMD module names starting with @angular when building angular downstream from source using Bazel. The underlying issue has been resolved in the compiler and these files now get proper AMD module names without the need for this workaround. The workaround had an unexpected consequence angular/angular-cli#11835 which is fixed by its removal.
gregmagolan
force-pushed
the
revert-amd-module-name-for-ngfactory
branch
from
81998de to
c4b36a9
Compare
alxhub
approved these changes
Aug 21, 2018
|
You can preview c4b36a9 at https://pr25604-c4b36a9.ngbuilds.io/. |
matsko
pushed a commit
that referenced
this pull request
Aug 23, 2018
… ngfactory & ngsummary files (#25604) Workaround was added in #25335. It was necessary for .ngfactory & .ngsummary files to have proper AMD module names starting with @angular when building angular downstream from source using Bazel. The underlying issue has been resolved in the compiler and these files now get proper AMD module names without the need for this workaround. The workaround had an unexpected consequence angular/angular-cli#11835 which is fixed by its removal. PR Close #25604
|
@alexeagle I think you said we also need another test for this |
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
… ngfactory & ngsummary files (angular#25604) Workaround was added in angular#25335. It was necessary for .ngfactory & .ngsummary files to have proper AMD module names starting with @angular when building angular downstream from source using Bazel. The underlying issue has been resolved in the compiler and these files now get proper AMD module names without the need for this workaround. The workaround had an unexpected consequence angular/angular-cli#11835 which is fixed by its removal. PR Close angular#25604
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves angular/angular-cli#11835.
The underlying issue in the compiler that required this workaround to give ngfactory & ngsummary files proper AMD names has been resolved so it is no longer needed.