-
Notifications
You must be signed in to change notification settings - Fork 25.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(animations): getAnimationStyle causes exceptions in older browsers #29709
Conversation
6a6e992
to
94d1810
Compare
@Serginho sorry this took us forever to get back to you on. Could you add a test to this? You would need to export the function you modified and import it into https://github.com/angular/angular/blob/master/packages/animations/browser/test/render/css_keyframes/element_animation_style_handler_spec.ts Then test by mocking out the a fake element a style property. |
fb2f0a8
to
bd07373
Compare
@matsko I didn't do any additional test because Lines 66 to 68 in 5bc39f8
So I assume you want a testcase for this bug, and this is what I did in the updated commit. Let me know if you need something else. |
6f9210a
to
9625229
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - please can you add some more information to the commit message body?
@Serginho - would you mind rebasing this PR on top of master. Then I will try to chase reviewers to get it merged. |
9625229
to
8865d0c
Compare
PR angular#29709 getAnimationStyle causes exceptions in older browsers
8865d0c
to
ba35a0f
Compare
@petebacondarwin Sure. Rebased and ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for rebasing @Serginho. Just one minor correction in the test.
packages/animations/browser/test/render/css_keyframes/element_animation_style_handler_spec.ts
Outdated
Show resolved
Hide resolved
PR angular#29709 getAnimationStyle causes exceptions in older browsers
ba35a0f
to
2e26399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks.
packages/animations/browser/src/render/css_keyframes/element_animation_style_handler.ts
Show resolved
Hide resolved
@Serginho this PR is now merged, thanks for contributing to Angular! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #24094
What is the new behavior?
Animation doesn't break in old browsers now
Does this PR introduce a breaking change?
Other information