Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ngcc): insert definitions after statement #34677

Closed
wants to merge 1 commit into from
Closed

fix(ngcc): insert definitions after statement #34677

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Contributor

If a class was defined as a class expression
in a variable declaration, the definitions
were being inserted before the statment's
final semi-colon.

Now the insertion point will be after the
full statement.

Fixes #34648

@petebacondarwin
fix(ngcc): insert definitions after statement
0e63839 
If a class was defined as a class expression
in a variable declaration, the definitions
were being inserted before the statment's
final semi-colon.

Now the insertion point will be after the
full statement.

Fixes angular#34648
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer effort1: hours target: patch This PR is targeted for the next patch release comp: ngcc labels Jan 8, 2020
@petebacondarwin petebacondarwin added this to the v9-blockers milestone Jan 8, 2020
@petebacondarwin petebacondarwin requested a review from a team as a code owner January 8, 2020 15:04
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 8, 2020
alxhub pushed a commit that referenced this pull request Jan 8, 2020
@petebacondarwin @alxhub
fix(ngcc): insert definitions after statement (#34677)
f295240 
If a class was defined as a class expression
in a variable declaration, the definitions
were being inserted before the statment's
final semi-colon.

Now the insertion point will be after the
full statement.

Fixes #34648

PR Close #34677
@alxhub alxhub closed this in 8815ace Jan 8, 2020
@petebacondarwin petebacondarwin deleted the ngcc-empty-statement-fix branch January 9, 2020 13:57
@alan-agius4 alan-agius4 mentioned this pull request Jan 17, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
v9-blockers
Development

Successfully merging this pull request may close these issues.

lvy:Library build by angular-cli can not tree shaking in apps
3 participants
@petebacondarwin @gkalpak @googlebot