chore(docs): explain the process for merging changes to master #3566
Conversation
| If the automation fails, committers can also push to a branch following this naming scheme. | ||
|
|
||
| When a Travis build succeeds for a branch named `presubmit-*`, Travis will re-base the PR and merge to master | ||
| automatically. |
mhevery
added
pr_state: LGTM
action: cleanup
alexeagle
force-pushed
the
committer
branch
2 times, most recently
from
c2511a6 to
9650848
Compare
| We have automated the process for merging pull requests into master. Our goal is to minimize the disruption for | ||
| Angular committers and also prevent breakages on master. | ||
|
|
||
| When a PR is ready to merge, a project member in [this list] should add the special label, |
There was a problem hiding this comment.
where is the list? how do we add people? looks like they are just stored in the app engine DB
https://github.com/mhevery/angular2-automation/blob/4606b6a4837a69a913d57eb8a6257d1199356821/helloworld.py#L15
but how do we see the list, where is the app hosted?
There was a problem hiding this comment.
I don't know enought about AppEngine to know how to share the rights of the app with the wider group. Yes it is stored in DB
There was a problem hiding this comment.
Added enough of a pointer so someone can track this down when needed.
On Mon, Aug 10, 2015 at 1:34 PM Miško Hevery notifications@github.com
wrote:
In COMMITTER.md
#3566 (comment):@@ -0,0 +1,24 @@
+# Pushing changes into the Angular 2 tree
+
+Please see Using git with Angular repositories
+for details about how we maintain a linear commit history, and the rules for committing.
+
+As a contributor, just read the instructions in CONTRIBUTING.md and send a pull request.
+Someone with committer access will do the rest.
+
+## ThePR: mergelabel andpresubmit-*branches
+
+We have automated the process for merging pull requests into master. Our goal is to minimize the disruption for
+Angular committers and also prevent breakages on master.
+
+When a PR is ready to merge, a project member in [this list] should add the special label,I don't know enought about AppEngine to know how to share the rights of
the app with the wider group. Yes it is stored in DB—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular/pull/3566/files#r36680834.
tbosch
added
action: merge
mary-poppins
removed
the
action: merge
|
Merging PR #3566 on behalf of @tbosch to branch presubmit-tbosch-pr-3566. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.