Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename modules/examples to modules/playground #4639

Closed
wants to merge 1 commit into from
Closed

Rename modules/examples to modules/playground #4639

wants to merge 1 commit into from

Conversation

kutyel
Copy link
Contributor

@kutyel kutyel commented Oct 9, 2015

Closes #4342

Is there any other reference to this folder or something else that I'm missing?

@IgorMinar
Copy link
Contributor

there are references in the gulp file, and also in dart_tree.ts, browser_tree.ts and node_tree.ts

@IgorMinar IgorMinar self-assigned this Oct 14, 2015
@IgorMinar
Copy link
Contributor

can you fix that please and rebase?

@IgorMinar IgorMinar added type: chore refactoring Issue that involves refactoring or code-cleanup labels Oct 14, 2015
@IgorMinar IgorMinar added this to the alpha-43 milestone Oct 14, 2015
@kutyel
Copy link
Contributor Author

kutyel commented Oct 14, 2015

@IgorMinar Done, I just rebased and left one single commit. I couldn't find the references you mention in the node_tree.ts file, the rest are just fine. Give some feedback when you have time 😉

@IgorMinar
Copy link
Contributor

@kutyel looks better, but there are still conflicts. can you rebase one more time please?

@kutyel
Copy link
Contributor Author

kutyel commented Oct 15, 2015

@IgorMinar Done, thanks for the assistance 😄

@IgorMinar
Copy link
Contributor

Sorry, there are still some test failures. looks like you missed a rename somewhere that is affecting e2e tests. Can you please look into it (and rebase against master again + squash everything into one commit).

Lastly, please change the commit message to:

chore: rename modules/examples to modules/playground

The directory contains code authored in a style that makes it transpilable to dart. As such, these are not idiomatic examples of Angular 2 usage.

The main purpose of this directory is to enable experimentation with Angular within the angular/angular repository.

Closes #4342

Thanks

@IgorMinar
Copy link
Contributor

@IgorMinar
Copy link
Contributor

sorry, I know that this is back and forth frustrating..

The directory contains code authored in a style that makes it transpilable to dart. As such, these are not idiomatic examples of Angular 2 usage.

The main purpose of this directory is to enable experimentation with Angular within the angular/angular repository.

Closes #4342
@kutyel
Copy link
Contributor Author

kutyel commented Oct 18, 2015

@IgorMinar I finally made it! Don't worry, putting aside the initial frustration, I'm very happy to contribute to such an awesome project! 😄

@IgorMinar IgorMinar added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Oct 18, 2015
@mary-poppins
Copy link

Merging PR #4639 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4639.

1 similar comment
@mary-poppins
Copy link

Merging PR #4639 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4639.

@mary-poppins mary-poppins removed action: merge The PR is ready for merge by the caretaker labels Oct 18, 2015
@IgorMinar
Copy link
Contributor

Merged! Thanks!

@mhevery mhevery closed this in e4e74ae Oct 18, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes refactoring Issue that involves refactoring or code-cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename modules/examples directory to modules/dev-playground or modules/playground
4 participants