Skip to content

refactor(http): rework the HttpEvent union to improve narrowing. #63267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(http): rework the HttpEvent union to improve narrowing. #63267

wants to merge 1 commit into from
+18 −3

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Aug 20, 2025

Prior to this change, HttpProgressEvent could not be narrowed to HttpDownloadProgressEvent or HttpUploadProgressEvent

@pullapprove pullapprove bot requested a review from kirjs August 20, 2025 08:59
@JeanMeche JeanMeche added the action: global presubmit The PR is in need of a google3 global presubmit label Aug 20, 2025
@angular-robot angular-robot bot added the area: common/http Issues related to HTTP and HTTP Client label Aug 20, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 20, 2025
JoostK
JoostK reviewed Aug 20, 2025
View reviewed changes
@JeanMeche JeanMeche force-pushed the http-event-narrowing branch from 31893bc to 4d2376c Compare August 20, 2025 11:12
@JeanMeche
refactor(http): rework the HttpEvent union to improve narrowing.
4115855 
Prior to this change, `HttpProgressEvent` could not be narrowed to `HttpDownloadProgressEvent` or `HttpUploadProgressEvent`
@JeanMeche JeanMeche force-pushed the http-event-narrowing branch from 4d2376c to 4115855 Compare August 20, 2025 12:13
@JeanMeche JeanMeche added the target: patch This PR is targeted for the next patch release label Aug 20, 2025
@JeanMeche JeanMeche linked an issue Aug 20, 2025 that may be closed by this pull request
Can't access partialText on an HttpProgressEvent unless I cast it first #63254
Closed
@JeanMeche
Copy link
Member Author

JeanMeche commented Aug 20, 2025

TGP is "green"

@JeanMeche JeanMeche removed the action: global presubmit The PR is in need of a google3 global presubmit label Aug 20, 2025
thePunderWoman
thePunderWoman approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-general, public-api

mmalerba
mmalerba approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 27, 2025
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Aug 27, 2025

This PR was merged into the repository. The changes were merged into the following branches:

AndrewKushnir pushed a commit that referenced this pull request Aug 27, 2025
@JeanMeche @AndrewKushnir
refactor(http): rework the HttpEvent union to improve narrowing. (#…
e8d9bc5 
…63267)

Prior to this change, `HttpProgressEvent` could not be narrowed to `HttpDownloadProgressEvent` or `HttpUploadProgressEvent`

PR Close #63267
@JeanMeche JeanMeche mentioned this pull request Aug 27, 2025
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 27, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK left review comments

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Can't access partialText on an HttpProgressEvent unless I cast it first

5 participants

@JeanMeche @AndrewKushnir @JoostK @thePunderWoman @mmalerba