Skip to content

docs(LifecycleHooks): correct ngDoCheck description #8807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2016
Merged

docs(LifecycleHooks): correct ngDoCheck description #8807

merged 1 commit into from
May 26, 2016

Conversation

zbjornson
Copy link
Contributor

@zbjornson zbjornson commented May 24, 2016

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Doc fix

What is the current behavior? (You can also link to an open issue here)
Docs describe incorrect behavior. (See #6810 and #7307.)

What is the new behavior?
Docs describe current actual behavior.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information:

The current behavior is for ngDoCheck to supplement, not override, the default change detector. OnChanges will still be called when DoCheck is implemented (fixes #7307, #6810).

I assume the desired behavior of ngDoCheck has been discussed. What the docs described actually sounds nice, both from a usage and performance perspective, but @mhevery's comment in #7307 suggests that the current behavior is as-intended.

The current behavior is for ngDoCheck to supplement, not override, the default change detector. OnChanges will still be called when DoCheck is implemented (fixes #7307).
@mhevery mhevery merged commit 3a62023 into angular:master May 26, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngOnChanges called when ngDoCheck implemented
3 participants