Skip to content

Commit

Permalink
fix(): Zone already loaded, type implied (#1631)
Browse files Browse the repository at this point in the history 
I'm seeing complaints that #1599 didn't go far enough. It seems the Zone calls are fine being implicitly loaded; so let's drop the import completely.
  • Loading branch information
@jamesdaniels
jamesdaniels authored May 12, 2018
1 parent 570c0a7 commit 7d2fd53
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/core/angularfire2.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import { first } from 'rxjs/operators';
import firebase from '@firebase/app';
import { FirebaseApp, FirebaseOptions, FirebaseAppConfig } from '@firebase/app-types';

import {} from 'zone.js';

export const FirebaseAppNameToken = new InjectionToken<string|undefined>('angularfire2.app.name');
export const FirebaseOptionsToken = new InjectionToken<FirebaseOptions>('angularfire2.app.options');
export const FirebaseAppConfigToken = new InjectionToken<FirebaseAppConfig|undefined>('angularfire2.app.config');
Expand Down

6 comments on commit 7d2fd53

@LordDraagonLive
Copy link

@LordDraagonLive LordDraagonLive commented on 7d2fd53 May 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still calling AngularFireModule.initializeApp(FIREBASE_CONFIG), will give out the zone already loaded error.
@jamesdaniels @JiaLiPassion


Error in console 

  at vendor.js:126386
  at vendor.js:126998
  at FUNCTION (vendor.js:126363)
  at Object.<anonymous> (vendor.js:126366)
  at Object.<anonymous> (vendor.js:129416)
  at __webpack_require__ (vendor.js:55)
  at Object.__extends (vendor.js:77000)
  at __webpack_require__ (vendor.js:55)
  at Object.<anonymous> (vendor.js:126085)
  at __webpack_require__ (vendor.js:55)

vendor.js:126386 Uncaught Error: Zone already loaded.
  at vendor.js:126386
  at vendor.js:126998
  at FUNCTION (vendor.js:126363)
  at Object.<anonymous> (vendor.js:126366)
  at Object.<anonymous> (vendor.js:129416)
  at __webpack_require__ (vendor.js:55)
  at Object.__extends (vendor.js:77000)
  at __webpack_require__ (vendor.js:55)
  at Object.<anonymous> (vendor.js:126085)
  at __webpack_require__ (vendor.js:55)    ```


  ###My Environment

cli packages: (C:\Users\Acer\AppData\Roaming\npm\node_modules)

@ionic/cli-utils  : 1.19.2
ionic (Ionic CLI) : 3.20.0

global packages:

cordova (Cordova CLI) : 8.0.0

local packages:

@ionic/app-scripts : 3.1.9
Cordova Platforms  : android 7.0.0
Ionic Framework    : ionic-angular 3.9.2

System:

Android SDK Tools : 26.1.1
Node              : v8.11.1
npm               : 6.0.1
OS                : Windows 10

Environment Variables:

ANDROID_HOME : F:\Acer\AppData\Local\Android\Sdk

Misc:

backend : pro

@jamesdaniels
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version are you running? This fix is only available in angularfire2@next

@LordDraagonLive
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesdaniels ah.. sorry mate my bad. I did a basic installation, angularfire2 i'll try it and inform you.

@jamesdaniels
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, once the PR is merged we'll release a "normal" release. If you have any issues with @next file a new issue.

@LordDraagonLive
Copy link

@LordDraagonLive LordDraagonLive commented on 7d2fd53 May 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @jamesdaniels angularfire2@next worked. Thank you very much you guys are doing a great job

@jamesdaniels
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Np. Good to hear.

Please sign in to comment.