Skip to content

database module typescript definition: update signature is wrong #1329

Closed
@phra

Description

@phra

Hi,

there is a bug in the new database typescript definitions.

https://github.com/angular/angularfire2/blob/master/src/database/list/create-reference.ts#L11
i think that line no. 6 should be:

update: createDataOperationMethod<Partial<T>>(query.ref, 'update'),

otherwise the non destructive .update() wants as second arguments a complete T object instead of a Partial.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions