Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore document set method missing options parameter #1332

Closed
moneal opened this issue Nov 7, 2017 · 0 comments
Closed

Firestore document set method missing options parameter #1332

moneal opened this issue Nov 7, 2017 · 0 comments

Comments

@moneal
Copy link
Contributor

moneal commented Nov 7, 2017

Version info

Angular: *

Firebase: *

AngularFire: 5.0.0-rc3

How to reproduce these conditions

Calling set on a document reference that does not exist causes a error. The set options parameter is missing from the set method in angularfire2. With options is possible to set values on a document that doesn't yet exist.

Expected behavior

Allow the same parameters as DocumentReference's set method in firebase JS API.

Actual behavior

Browser when entity does not exist: ERROR Error: Uncaught (in promise): FirebaseError: [code=not-found]: no entity to update
Typescript Lint: [ts] Expected 1 arguments, but got 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant