Error: Zone already loaded. #1597

Celtiore · 2018-05-05T12:40:15Z

Hi,
1/ thanks you for your great job
2/ sorry for my english, i'm french :)
3/ i'm a beginner
4/ i'm not sure it's a bug
5/ i'm not sure it's the right place

this morning i'have updated "angularfire2": "^5.0.0-rc.6" to "angularfire2": "^5.0.0-rc.7"

6/ my working code with rc.6 does not work anymore
this.afsClient = new AngularFirestore(_firebaseAppFactory(configFirebase, 'firebaseClient'), false);
because with rc.7 :
(alias) new AngularFirestore(config: FirebaseOptions, name: string, shouldEnablePersistence: boolean, platformId: Object, zone: NgZone)

7/ i start a new blank project ( see github link below ) and now i have the zone.js error !

8/ can you explain me the correct syntax for platformId: Object, zone: NgZone

9/ thanks you

Version info

Angular:
"@angular/common": "5.2.10"
Firebase:
"firebase": "^4.13.1"
AngularFire:
"angularfire2": "^5.0.0-rc.7"

Other (e.g. Ionic/Cordova, Node, browser, operating system):
"ionic-angular": "3.9.2"

How to reproduce these conditions

https://github.com/Celtiore/test-angularfire2

Debug output

Uncaught Error: Zone already loaded.
at zone.js:32
at zone.js:644
at FUNCTION (zone.js:9)
at Object. (zone.js:12)
at Object. (zone.js:3060)
at webpack_require (bootstrap 5a89165deffa5ae45da5:54)
at Object.defineProperty.value (vendor.js:77357)
at webpack_require (bootstrap 5a89165deffa5ae45da5:54)
at Object. (vendor.js:125168)
at webpack_require (bootstrap 5a89165deffa5ae45da5:54)

fjoalland · 2018-05-05T15:48:58Z

Hello,

I have exactly the same issue than you. I think it's because of the version of angularfire2 but not sure, I will try something and if it works I will tell you.

fjoalland · 2018-05-05T16:23:39Z

Change this version in your package.json

    "angularfire2": "^5.0.0-rc.4",
    "firebase": "^4.6.2",

ngocongcan · 2018-05-05T16:58:39Z

Still happens 👎

ghost · 2018-05-05T16:59:55Z

+1

JiaLiPassion · 2018-05-05T17:15:04Z

@jamesdaniels , I think the issue is here, https://github.com/angular/angularfire2/blob/master/src/core/angularfire2.ts#L11,
why we need to import 'zone.js' here? I believe in browser or universal environment, zone.js should already be loaded.

Do we just need the Typing?
But I see in tsconfig.json,

    "../../node_modules/zone.js/dist/zone.js.d.ts"

has already been loaded, so I am not sure why we need to import zone.js, I delete the import and everything works fine, so this is an universal issue?

Celtiore · 2018-05-05T19:42:57Z

thanks you @JiaLiPassion
wait and see now :)

+ RC 7 got a bug with zone already loaded in their node_modules. + Will revert back when the fix is impemented. --- angular/angularfire#1597

Celtiore · 2018-05-06T07:36:49Z

@JiaLiPassion , i try to modify nodes_modules/angularfire2/angularfire2.js and nodes_modules/angularifre2.d.ts in my project, but i have same error ?

JiaLiPassion · 2018-05-06T12:45:17Z

@Celtiore, you can try the attached zip file
dist.zip

, and I also updated your project, src/providers/af/af.ts.
you need to pass ngZone to create a new AngularFirestore.

import {Injectable, NgZone} from '@angular/core';
import {AngularFirestore} from 'angularfire2/firestore';
import {firebaseConfig} from '../../app/app.module';

@Injectable()
export class AfProvider {
  canUexplainMe2: any;

  afsClient: AngularFirestore;

  constructor(private ngZone: NgZone) {
    console.log('Hello AfProvider Provider');
  }
  createAFS() {
    this.afsClient = new AngularFirestore(
        firebaseConfig, 'firebaseUsers', false, 'can you explain me',
        this.ngZone);
  }
}

Celtiore · 2018-05-06T14:49:00Z

Ok, i try later,
thanks you @JiaLiPassion

Celtiore · 2018-05-06T15:34:52Z

thanks you so much, can't wait later to try :) :) :)

working fine

repo updated :

https://github.com/Celtiore/test-angularfire2

Can we close this issue ?

JiaLiPassion · 2018-05-06T15:37:12Z

@Celtiore , thank you for confirm, I am not sure why import 'zone.js'; is there , so we can close it when we confirm the reason with the angularfire2 team.

AnthonyNahas · 2018-05-07T07:17:31Z

@JiaLiPassion I am not sure why import 'zone.js' --> I think that fixed the problem when angularfire is running outside angular... like in nodejs for server side rendering...
Anyway, I am getting the same error after updating angularfire2 to version 5.0.0-rc.7!
Downgrading is in progress 📦 ... This helps!

JiaLiPassion · 2018-05-07T09:19:06Z

@AnthonyNahas , in nodejs or server side rendering, zone-node.js is already been loaded.
So I think it is not necessary to import it again.

Nilesh-TA · 2018-05-09T10:42:54Z

Hi @JiaLiPassion

I am facing same issue "Zone already loaded". Can you please help me.

See below info

Version info

Angular:
"@angular/common": "5.2.10"
Firebase:
"firebase": "^5.0.1"
AngularFire:
"angularfire2": "^5.0.0-rc.7"

Other (e.g. Ionic/Cordova, Node, browser, operating system):
"ionic-angular": "3.9.2"

Debug output

JiaLiPassion · 2018-05-09T11:42:57Z

@Nilesh-TA , for now, you can downgrade to 5.0.0-rc.4 or use this zip https://github.com/angular/angularfire2/files/1977627/dist.zip for test

Nilesh-TA · 2018-05-09T11:50:55Z

Thanks @JiaLiPassion.

I will try this.

nikjeni · 2018-05-09T18:42:45Z

@JiaLiPassion
Still it is not working. Even i have the same version as @Nilesh-TA mentioned in his comment. But still it is giving same error "zone already loaded".
Please help me to resolve this

nikjeni · 2018-05-09T18:45:57Z

@JiaLiPassion well done. i fixed it with zip which you uploaded.
Thank you

Celtiore · 2018-05-09T21:20:27Z

thanks you @JiaLiPassion @jamesdaniels

https://github.com/angular/angularfire2/pull/1599/files/aefedc2af5026e00b6344ff3d9249ecf7dbf6c7b

Arlette-Liliane · 2018-05-10T11:47:25Z

i hav same problem,
i fixed with : npm update angularfire2
New version in package.json : "angularfire2": "^5.0.0-rc.5-next"

csotomon · 2018-05-11T14:06:26Z

this is solved in 5.0.0-rc.5-next, but i had to downgrade firebase to firebase@^4.13.1

rahuljograna · 2018-05-12T04:16:31Z

This is the problem of new firebase update, here is a solution for this error

** Step: 1** Install the lower version of firebase using this command

npm install angularfire2@5.0.0-rc.4

** Step: 2**

npm install

Try.

takahser · 2018-08-09T23:09:26Z

Didn't work for me!
I tried the following constellations:

"firebase": "4.13.1" and "angularfire2": "5.0.0-rc.5-next"
"angularfire2": "5.0.0-rc.11" and "firebase": "^5.0.2"
"angularfire2": "5.0.0-rc.11" and "firebase": "5.3.1"

I'm using Angular 6.

Any suggestions?

DanyalKhawaja · 2018-10-12T11:56:05Z

Solution to zone issue:
http://olengski.com/subpages/angular5/angular5.html

JiaLiPassion mentioned this issue May 5, 2018

fix(core): only import typing from zone.js #1599

Merged

thienn added a commit to thienn/BookMarket-Ionic-App that referenced this issue May 5, 2018

Rolling back to old configurations

e50deac

+ RC 7 got a bug with zone already loaded in their node_modules. + Will revert back when the fix is impemented. --- angular/angularfire#1597

JiaLiPassion mentioned this issue May 6, 2018

Runtime Error Zone already loaded angular/zone.js#1081

Closed

herkulano mentioned this issue May 7, 2018

ng test not working after upgrade to 6.0.0 angular/angular-cli#10485

Closed

Celtiore mentioned this issue May 7, 2018

ionic 3 not able to run. #1603

Closed

Celtiore closed this as completed May 9, 2018

crh225 mentioned this issue May 12, 2018

Angular 6 upgrade broke karma. Executed 0 of 0 Error angular/devkit#857

Closed

LordDraagonLive mentioned this issue May 13, 2018

Apptype LordDraagonLive/angularfire2#1

Merged

dramentol mentioned this issue Oct 26, 2018

Zone already loaded #1930

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error: Zone already loaded. #1597

Error: Zone already loaded. #1597

Celtiore commented May 5, 2018

fjoalland commented May 5, 2018

fjoalland commented May 5, 2018

ngocongcan commented May 5, 2018

ghost commented May 5, 2018

JiaLiPassion commented May 5, 2018 •

edited

Loading

Celtiore commented May 5, 2018 •

edited

Loading

Celtiore commented May 6, 2018

JiaLiPassion commented May 6, 2018 •

edited

Loading

Celtiore commented May 6, 2018

Celtiore commented May 6, 2018

JiaLiPassion commented May 6, 2018

AnthonyNahas commented May 7, 2018

JiaLiPassion commented May 7, 2018

Nilesh-TA commented May 9, 2018 •

edited

Loading

JiaLiPassion commented May 9, 2018

Nilesh-TA commented May 9, 2018

nikjeni commented May 9, 2018

nikjeni commented May 9, 2018

Celtiore commented May 9, 2018

Arlette-Liliane commented May 10, 2018

csotomon commented May 11, 2018 •

edited

Loading

rahuljograna commented May 12, 2018

takahser commented Aug 9, 2018

DanyalKhawaja commented Oct 12, 2018

Error: Zone already loaded. #1597

Error: Zone already loaded. #1597

Comments

Celtiore commented May 5, 2018

Version info

How to reproduce these conditions

Debug output

fjoalland commented May 5, 2018

fjoalland commented May 5, 2018

ngocongcan commented May 5, 2018

ghost commented May 5, 2018

JiaLiPassion commented May 5, 2018 • edited Loading

Celtiore commented May 5, 2018 • edited Loading

Celtiore commented May 6, 2018

JiaLiPassion commented May 6, 2018 • edited Loading

Celtiore commented May 6, 2018

Celtiore commented May 6, 2018

JiaLiPassion commented May 6, 2018

AnthonyNahas commented May 7, 2018

JiaLiPassion commented May 7, 2018

Nilesh-TA commented May 9, 2018 • edited Loading

JiaLiPassion commented May 9, 2018

Nilesh-TA commented May 9, 2018

nikjeni commented May 9, 2018

nikjeni commented May 9, 2018

Celtiore commented May 9, 2018

Arlette-Liliane commented May 10, 2018

csotomon commented May 11, 2018 • edited Loading

rahuljograna commented May 12, 2018

takahser commented Aug 9, 2018

DanyalKhawaja commented Oct 12, 2018

JiaLiPassion commented May 5, 2018 •

edited

Loading

Celtiore commented May 5, 2018 •

edited

Loading

JiaLiPassion commented May 6, 2018 •

edited

Loading

Nilesh-TA commented May 9, 2018 •

edited

Loading

csotomon commented May 11, 2018 •

edited

Loading