Skip to content

Won't build with Angular 10 #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shadow1349 opened this issue Jun 27, 2020 · 21 comments
Closed

Won't build with Angular 10 #2526

shadow1349 opened this issue Jun 27, 2020 · 21 comments

Comments

@shadow1349
Copy link

When I try to build or run my project it won't do either. It says that ModuleWithProviders<T> requires 1 type argument (screenshot attached below).

Version info

Angular: 10.0.1

Firebase: 7.15.1

AngularFire: 6.0.2

Other (e.g. Ionic/Cordova, Node, browser, operating system):

How to reproduce these conditions

Create an Angular 10 project (with @angular/core version 10.0.1). Add @angular/fire libary. Try to build.

Expected behavior

I should be able to build and run the project.

Actual behavior

Screenshot from 2020-06-26 23-42-45

@shadow1349
Copy link
Author

I tried downgrading to 10.0.0 and I got the same behavior.

@MC-Mihai
Copy link

You may want to check this link . It seems to me like support is only offered up to 8, but I could be wrong.

@shadow1349
Copy link
Author

shadow1349 commented Jun 28, 2020

@Mihai-MCW according to their changelog, 6.0.2 should work on angular 10 https://github.com/angular/angularfire/blob/master/CHANGELOG.md

@fritzschoff
Copy link

+1

@yasinkocak
Copy link
Contributor

yasinkocak commented Jun 29, 2020

I made a PR for this #2527

@shadow1349
Copy link
Author

@yasinkocak thank you!

@doivosevic
Copy link

I have the same problem. Can I just copy paste this here firestore.module.d.ts:7:74 - error TS2314: Generic type 'ModuleWithProviders' requires 1 type argument(s). because this is how I googled for the issue and didn't get any results

@BianchiSeb
Copy link

Hello angularFire team. I literally spend a ton of money in your app for my clients. At least answer us. It’s a shame that core features are broken.
It’s a shame you don’t manage the PR.
At least give us back the projets lead and we can manage it like a TRUE open source project.

@kaptain-ti
Copy link

set enableIvy to true in tsconfig and tsconfig.app

@shadow1349
Copy link
Author

@kaptain-ti I had to turn that off because I was using a custom decorator which is not supported by Ivy yet. If that issue is fixed in angular 10 then I will be able to turn ivy back on

@vtregner-cen29414
Copy link

Fix is already merged to master, but not released. Can you release new version? Due this issue I cannot update my library to Angular 10...

@doivosevic
Copy link

Wow, over 1 month for a type fix

@shadow1349
Copy link
Author

@vtregner you can install the canary version npm i @angular/fire@canary that has the fix in and is fully working.

@hlpupo
Copy link

hlpupo commented Aug 21, 2020

I have the same problem, any update?

@fritzschoff
Copy link

@hlpupo like @shadow1349 suggested, use the canary version. npm i @angular/fire@canary

@djabif
Copy link

djabif commented Sep 17, 2020

Is there an estimated date for releasing 6.0.3?

Fix is already merged to master, but not released. Can you release new version? Due this issue I cannot update my library to Angular 10...

@taylormills
Copy link

The fix for this was merged over 2 months ago, what's the hold up on releasing? I would rather not have production code relying on a canary version.

@doivosevic
Copy link

@davideast @jeffbcross can we in any way help speed up the process in general? I would really like to help blockers like these go into production code sooner. Angular 11 is around the corner and we still cannot build all stable libraries with 10

@vtregner-cen29414
Copy link

It seems the project is dead. Unbelievable ignorance.

@Splaktar
Copy link
Contributor

With the fix for #2505 getting into the latest Canary, it looks like (based on #2505 (comment)) that a 6.0.3 release is coming very soon.

@Splaktar
Copy link
Contributor

I found another place where ModuleWithProviders is needed and fixed it in PR: #2598.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests