Fix angular 10 style moduleWithProviders #2527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NothingEverHappens
approved these changes
Jun 29, 2020
|
+1 this is a big blocker for Angular 10 upgrade |
|
Where can we track the travis queue and progress? Can we get this in now? It's a blocker |
jamesdaniels
approved these changes
Jul 1, 2020
|
@jamesdaniels is there any action i should do for travis-ci? |
|
Looks like this is all good, can we get this merged please? |
|
For the love of god, just merge it! |
|
Hey all, sorry about the delay here. I'd been taking some vacation and just getting back to 6.0 patches this week. |
|
Any idea about new release date? Many thanks ;) |
|
@marzecm If you want to use it right away you can use the canary build which I've been using. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Generic typing ModuleWithProviders