Skip to content

screen_view events being auto logged regardless of ScreenTrackingService being provided #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jackcw opened this issue Sep 30, 2020 · 3 comments

Comments

@jackcw
Copy link
Contributor

jackcw commented Sep 30, 2020

The screen_view events are being auto logged regardless of ScreenTrackingService being provided in the module. The issue I have is that the screen_view events are giving an identifiable screen class name and so I'm going to do it manually and so need to deactivate the auto logging ones.

Version info

Angular: 10.1.3

Firebase: 7.21.1

AngularFire: 6.0.3

How to reproduce these conditions

Steps to set up and reproduce

import { AngularFireAnalyticsModule } from '@angular/fire/analytics';

@NgModule({
  imports: [
    AngularFireModule.initializeApp(environment.firebase),
    AngularFireAnalyticsModule
  ],
  providers: []
})
export class AppModule { }

Expected behavior

No screen_view changes to show up unless ScreenTrackingService is provided.

Actual behavior

Each route change a screen_view event is logged

@jackcw
Copy link
Contributor Author

jackcw commented Oct 1, 2020

PR provided to fix this #2605

@jamesgroat
Copy link

jamesgroat commented Oct 22, 2020

Workaround to disable this -- just provide a dummy class for the service:

{ provide: ScreenTrackingService, useValue: {}, },

Related to #2604

@jamesdaniels
Copy link
Member

Addressed in 6.0.4 which is being cut now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants