Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(afs): catch error when enabling persistence #1300

Merged
merged 1 commit into from
Oct 25, 2017
Merged

fix(afs): catch error when enabling persistence #1300

merged 1 commit into from
Oct 25, 2017

Conversation

Maistho
Copy link
Contributor

@Maistho Maistho commented Oct 22, 2017

Checklist

  • Docs included?: no
  • Test units included?: no
  • In a clean directory, npm install, npm run build, and npm test run successfully? yes

Description

Instead of getting an "Uncaught Promise" error in console, this will set the persistanceEnabled$ observable properly

@jamesdaniels jamesdaniels merged commit 61245a3 into angular:master Oct 25, 2017
@jamesdaniels
Copy link
Member

Nice one, I was planning on doing that this evening. Thanks!

@Maistho Maistho deleted the catch-persistence-error branch October 25, 2017 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maistho @jamesdaniels @googlebot