fix(): Fixing Zone.js issues #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow, thank you for this. 🥇 |
|
For me RC7 is not working. He says: "Uncaught Error: Zone already loaded." using Angular 5.2.10 and Ionic Angular 3.9.2. After downgrading to RC6 everything is working. I cannot provide any further details because I need to check it first, what fails. Maybe another user can take a look, too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? yesDescription
Cleaning up some of the zone changes; further refactor is needed. Should fix change detection though.
I've published this PR as
5.0.0-rc.7.1-next/angularfire2@next.Code sample