fix(): Switching over to firebase from @firebase/*
#1677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdaniels
force-pushed
the
just_firebase
branch
from
664c2d6 to
d04ebd0
Compare
jamesdaniels
commented
May 22, 2018
| // app.App database() doesn't take a databaseURL arg in the public types? | ||
| database: (databaseURL?: string) => FirebaseDatabase; | ||
| // automaticDataCollectionEnabled is now private? _automaticDataCollectionEnabled? | ||
| // automaticDataCollectionEnabled: true, |
There was a problem hiding this comment.
FYI @jshcrowthe, if this goes public again it's going to be a breaking change for us; as it was the first time; as we need to export an "implementing" class to ngModule.
There was a problem hiding this comment.
It would be a lot better for us if firebase/app exported FirebaseAppImpl, not just an interface; then we wouldn't have the chance of breaking changes.
jamesdaniels
commented
May 22, 2018
| automaticDataCollectionEnabled: boolean; | ||
| options: {}; | ||
| auth: () => FirebaseAuth; | ||
| // app.App database() doesn't take a databaseURL arg in the public types? |
jamesdaniels
commented
May 22, 2018
| return (existingApp || firebase.initializeApp(options, config)) as FirebaseApp; | ||
| const existingApp = apps.filter(app => app && app.name === config.name)[0]; | ||
| // We support FirebaseConfig, initializeApp's public type only accepts string; need to cast as any | ||
| return (existingApp || (initializeApp as any)(options, config)) as FirebaseApp; |
jamesdaniels
commented
May 22, 2018
| * @param events | ||
| */ | ||
| export function combineChanges(current: DocumentChange[], changes: DocumentChange[], events: DocumentChangeType[]) { | ||
| export function combineChanges<T>(current: DocumentChange<T>[], changes: DocumentChange<T>[], events: DocumentChangeType[]) { |
There was a problem hiding this comment.
These <T>'s are needed because we're pulling in our DocumentChange now.
jamesdaniels
commented
May 22, 2018
| 'angularfire2/functions': 'angularfire2.functions', | ||
| 'angularfire2/storage': 'angularfire2.storage', | ||
| 'zone.js': 'Zone' | ||
| 'angularfire2/storage': 'angularfire2.storage' |
There was a problem hiding this comment.
zone.js and @angular/compiler were not needed, dropped while I was in here.
jamesdaniels
commented
May 22, 2018
| import { FirebaseOptionsToken, FirebaseNameOrConfigToken } from './angularfire2'; | ||
| // Public types don't expose FirebaseOptions or FirebaseAppConfig | ||
| export type FirebaseOptions = {[key:string]: any}; | ||
| export type FirebaseAppConfig = {[key:string]: any}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? yesDescription
Per firebase/firebase-js-sdk#853 we're moving over to the
firebasedependency and it's public types, rather than@firebase/*and@firebase/*-types.