Skip to content

WIP Refactor build process #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

WIP Refactor build process #2117

wants to merge 15 commits into from

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Jun 21, 2019

  • Moving to ng-packagr to build @angular/fire's package
  • Moved the build script over to Typescript and simplified
  • Simplified the angularfire2 wrapper build process
  • Testing is done by the Angular CLI
  • All specs are now also run under Node
  • There's some warnings and dead code trimming happening, I need to double check what's up
  • Need to throughly test
  • Got some red tests

Builds are some 5x faster now, proper APF, and have non-flattened ES5 and ES2015 targets.

@jamesdaniels jamesdaniels added this to the 5.3.0 milestone Jun 23, 2019
@jamesdaniels
Copy link
Member Author

I might ship as 5.2.2, since this should fix AOT issues...

@jamesdaniels jamesdaniels modified the milestones: 5.3.0, 5.2.2 Jun 23, 2019
@matheo
Copy link

matheo commented Jul 13, 2019

@jamesdaniels please! this is required by our broken builds :(

@jburson
Copy link

jburson commented Sep 3, 2019

@jamesdaniels Any update on getting this fix out for AOT? This is preventing our upgrade to angular 8. Thanks!

@wiedzmin26
Copy link

@davideast
Could you review it? Please.........

@wiedzmin26
Copy link

@jamesdaniels @davideast What's holding from this PR to be merged?

@jamesdaniels
Copy link
Member Author

Right now we have some red tests that are concerning me, but unclear if those are flakes. I haven't had a chance to give it a full smoke test. I may put a prerelease on NPM if anyone is interested in helping out.

@wiedzmin26
Copy link

@jamesdaniels Please do it.

@1001daysofcode
Copy link

Is this dead?

@hakimio
Copy link

hakimio commented Dec 8, 2019

@jamesdaniels so, is the prerelease still coming?

@jamesdaniels
Copy link
Member Author

Sorry for the radio silence here. The red tests here have slowed my roll, I'm concerned about breaks; so I'll be targeting this for AngularFire 6 which will be released to officially support Angular 9.

TBH I've been putting a lot of effort into landing #2187.

@matheo
Copy link

matheo commented Dec 19, 2019

Thanks @jamesdaniels! Awesome stuff!

@jamesdaniels
Copy link
Member Author

Dropping in favor of #2282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants