-
Notifications
You must be signed in to change notification settings - Fork 2.2k
WIP Refactor build process #2117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I might ship as 5.2.2, since this should fix AOT issues... |
@jamesdaniels please! this is required by our broken builds :( |
@jamesdaniels Any update on getting this fix out for AOT? This is preventing our upgrade to angular 8. Thanks! |
@davideast |
@jamesdaniels @davideast What's holding from this PR to be merged? |
Right now we have some red tests that are concerning me, but unclear if those are flakes. I haven't had a chance to give it a full smoke test. I may put a prerelease on NPM if anyone is interested in helping out. |
@jamesdaniels Please do it. |
Is this dead? |
@jamesdaniels so, is the prerelease still coming? |
Sorry for the radio silence here. The red tests here have slowed my roll, I'm concerned about breaks; so I'll be targeting this for AngularFire 6 which will be released to officially support Angular 9. TBH I've been putting a lot of effort into landing #2187. |
Thanks @jamesdaniels! Awesome stuff! |
Dropping in favor of #2282 |
ng-packagr
to build@angular/fire
's packageangularfire2
wrapper build processBuilds are some 5x faster now, proper APF, and have non-flattened ES5 and ES2015 targets.