-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[messaging] using navigator serviceWorker #2497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update new message source from serviceWorker instead of messaging observable
@yasinkocak I just push new code, that pass the Javis Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, this should help. Approved. I'll play around with this a bit and then merge.
It also seems a fix is coming upstream firebase/firebase-js-sdk#3221 |
perfect, I will update my PR once they complete that change @jamesdaniels |
@hiepxanh , can you Told me the right version of @angular/fire and firebasejs from gstatic because i have also the issue that when i'm not receiving an notification |
|
it is imposible to fix this, some how big problem come from |
Close since firebase release new version that fix this bug, I think we need to update the document, because I have serious trouble, the message in |
Checklist
base on this solution #1904 (comment)
yarn install
,yarn test
run successfully? yesDescription
fixing a bug because
this.angularFireMessaging.messages
not trigger new message any moreCode sample
nothing changes