-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Upgrade to exp #2770
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Firebase has released new version, when is this PR available? |
Moving this to the main branch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental AngularFire
👋 Hello everyone! As some of you may know, we are working on an experimental version of the Firebase JS SDK. This new version has a familiar API, but it is organized with small tree-shakeable functions instead of classes and namespaces. Check out this detailed article from website linked above if you want a deeper explanation.
This PR is an experiment to upgrade AngularFire to use this new library. The goals of the PR are to:
Due to the class based nature of AngularFire, the current API is not able to fully take advantage of tree-shaking. In order to fully take advantage of all the size reduction benefits we will need a new API. Upgrading to a new API may not seem like an appetizing task to you, and we fully understand that. To make the transition easier we will attempt to do our best to keep the current API stable alongside the new API. This means in future versions of AngularFire you will be able to use the current API while upgrading to the new one. We imagine that the size savings from the new API will be well worth the effort. We also have a few new features planned for this new API that I'll detail in a later PR.
So sit tight for now. There's nothing too interesting going on here, but there will be soon!