Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Upgrade to exp #2770

Merged
merged 59 commits into from
Aug 19, 2021
Merged

feat(core): Upgrade to exp #2770

merged 59 commits into from
Aug 19, 2021

Conversation

davideast
Copy link
Member

@davideast davideast commented Mar 9, 2021

Experimental AngularFire

👋 Hello everyone! As some of you may know, we are working on an experimental version of the Firebase JS SDK. This new version has a familiar API, but it is organized with small tree-shakeable functions instead of classes and namespaces. Check out this detailed article from website linked above if you want a deeper explanation.

This PR is an experiment to upgrade AngularFire to use this new library. The goals of the PR are to:

  • Refactor to the new library without breaking the current API (as much as we possibly can)
  • Get a green and stable build
  • Measure the size reduction

Due to the class based nature of AngularFire, the current API is not able to fully take advantage of tree-shaking. In order to fully take advantage of all the size reduction benefits we will need a new API. Upgrading to a new API may not seem like an appetizing task to you, and we fully understand that. To make the transition easier we will attempt to do our best to keep the current API stable alongside the new API. This means in future versions of AngularFire you will be able to use the current API while upgrading to the new one. We imagine that the size savings from the new API will be well worth the effort. We also have a few new features planned for this new API that I'll detail in a later PR.

So sit tight for now. There's nothing too interesting going on here, but there will be soon!

@jamesdaniels jamesdaniels mentioned this pull request Mar 10, 2021
@yasinkocak
Copy link
Contributor

Firebase has released new version, when is this PR available?

@jamesdaniels jamesdaniels marked this pull request as ready for review August 19, 2021 09:26
@jamesdaniels
Copy link
Member

Moving this to the main branch!

@jamesdaniels jamesdaniels merged commit b34b218 into master Aug 19, 2021
@jamesdaniels jamesdaniels deleted the exp branch August 19, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants