Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flushing out the new API #2963

Merged
merged 7 commits into from
Oct 6, 2021
Merged

Flushing out the new API #2963

merged 7 commits into from
Oct 6, 2021

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Sep 16, 2021

  • Adding ScreenTrackingService and UserTrackingService for the new API
  • Injectable classes should all be implicitly optional, since I can't figure out how to bail from the factory
  • Drop the memoization as the modules are idempotent in v9
  • Return null from analytics and messaging when they're incompatible, rather than a null object
  • Now test for browser and return null otherwise for remote config and performance
  • Allow more advanced initialization in provide* by allowing the developer to pass deps into the N+1 args & use the injector in the factory
  • Use AppCheck debug token if they're serving off localhost too, e.g, ng deploy --preview
  • Upgrade Firebase to 9.1
  • Utilize isSupported for Remote Config

Follow on:

  • Add the auth guards
  • Flush out new performance API
  • Flush out new RC API
  • Flush out new analytics API
  • Flush out new messaging API
  • Add the storgae pipe into the new API
  • Make sure compat + new API play well together

@jamesdaniels jamesdaniels marked this pull request as ready for review October 6, 2021 14:00
@jamesdaniels jamesdaniels merged commit d724d81 into master Oct 6, 2021
@jamesdaniels jamesdaniels deleted the flushing_out_new_api branch October 6, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants