Skip to content

fix(schematics): ng-add should pass if sourceRoot is relative to workspace root #3053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jamesdaniels merged 1 commit into from
Nov 11, 2021
Merged

fix(schematics): ng-add should pass if sourceRoot is relative to workspace root #3053

jamesdaniels merged 1 commit into from
Nov 11, 2021

Conversation

@AgentEnder
Copy link
Contributor

@AgentEnder AgentEnder commented Nov 9, 2021

Checklist

Description

Closes #3052

Code sample

@google-cla google-cla bot added the cla: yes label Nov 9, 2021
jamesdaniels
jamesdaniels reviewed Nov 10, 2021
View reviewed changes
@AgentEnder AgentEnder force-pushed the fix/schematics/ngadd-sourceroot branch from 6daffdb to 178ea58 Compare November 10, 2021 19:43
jamesdaniels
jamesdaniels approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jamesdaniels jamesdaniels merged commit 7e931cb into angular:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ng g @angular/fire:ng-add fails in a project where sourceRoot starts with the project's root

2 participants

@AgentEnder @jamesdaniels