Target ng16 #3361
Merged
Target ng16 #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jamesdaniels
commented
May 26, 2023
•
jamesdaniels
commented
- Allow peer of ng 16
- Cleanup ng-add to use web frameworks
- Deploy config version 2
- Cleanup tests
robertIsaac
reviewed
May 27, 2023
| @@ -244,79 +244,8 @@ function measureLibrary() { | |||
| return Promise.all(UMD_NAMES.map(measure)); | |||
| } | |||
|
|
|||
| async function buildDocs() { | |||
There was a problem hiding this comment.
why did you remove buildDocs? if it's because of the windows error I already found the fix for it I can open a PR to return it and fix it on windows
There was a problem hiding this comment.
I had originally had a custom tsdocs viewer planned but it didn’t go anywhere. I’m just aggressively trimming in an attempt to pair things back so we can (if possible) be built purely by ngc.
There was a problem hiding this comment.
I think the whole project can be quickly converted into nx workspace, but I'm not sure if in Google you are keen to use it
I can start converting it to nx if that's something will be approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.