This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 60
Fix enum bug in module legacy namespace. #928
Open
nbeloglazov
wants to merge
1
commit into
angular:master
Choose a base branch
from
nbeloglazov:b872
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
src/test/java/com/google/javascript/clutz/testdata/partial/declare_legacy_namespace_enu.d.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// Generated from src/test/java/com/google/javascript/clutz/testdata/partial/declare_legacy_namespace_enu.js | ||
declare namespace ಠ_ಠ.clutz.declare.legacy.namespace.enu { | ||
export import E = module$contents$declare$legacy$namespace$enu_E ; | ||
} | ||
declare module 'goog:declare.legacy.namespace.enu' { | ||
import enu = ಠ_ಠ.clutz.declare.legacy.namespace.enu; | ||
export = enu; | ||
} | ||
// Generated from src/test/java/com/google/javascript/clutz/testdata/partial/declare_legacy_namespace_enu.js | ||
declare namespace ಠ_ಠ.clutz { | ||
enum module$contents$declare$legacy$namespace$enu_E { | ||
A = 1.0 , | ||
B = 2.0 , | ||
C = 3.0 , | ||
} | ||
} | ||
declare namespace ಠ_ಠ.clutz.module$exports$declare$legacy$namespace$enu { | ||
export import E = ಠ_ಠ.clutz.module$contents$declare$legacy$namespace$enu_E ; | ||
} |
17 changes: 17 additions & 0 deletions
17
src/test/java/com/google/javascript/clutz/testdata/partial/declare_legacy_namespace_enu.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// This test is the same as declare_legacy_namespace_enum.js with the | ||
// difference that it doesn't use "enum" which is reserved keyword and triggers | ||
// separate flow in Clutz. | ||
|
||
goog.module('declare.legacy.namespace.enu'); | ||
goog.module.declareLegacyNamespace(); | ||
|
||
/** | ||
* @enum {number} | ||
*/ | ||
const E = { | ||
A: 1, | ||
B: 2, | ||
C: 3 | ||
}; | ||
|
||
exports.E = E; |
18 changes: 18 additions & 0 deletions
18
...test/java/com/google/javascript/clutz/testdata/partial/declare_legacy_namespace_enum.d.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
declare namespace ಠ_ಠ.clutz.declare.legacy { | ||
let namespace : { enum : { E : module$contents$declare$legacy$namespace$enum_E } }; | ||
} | ||
declare module 'goog:declare.legacy.namespace.enum' { | ||
import enum_ = ಠ_ಠ.clutz.declare.legacy.namespace; | ||
export default enum_.enum; | ||
} | ||
// Generated from src/test/java/com/google/javascript/clutz/testdata/partial/declare_legacy_namespace_enum.js | ||
declare namespace ಠ_ಠ.clutz { | ||
enum module$contents$declare$legacy$namespace$enum_E { | ||
A = 1.0 , | ||
B = 2.0 , | ||
C = 3.0 , | ||
} | ||
} | ||
declare namespace ಠ_ಠ.clutz.module$exports$declare$legacy$namespace$enum { | ||
export import E = ಠ_ಠ.clutz.module$contents$declare$legacy$namespace$enum_E ; | ||
} |
13 changes: 13 additions & 0 deletions
13
src/test/java/com/google/javascript/clutz/testdata/partial/declare_legacy_namespace_enum.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
goog.module('declare.legacy.namespace.enum'); | ||
goog.module.declareLegacyNamespace(); | ||
|
||
/** | ||
* @enum {number} | ||
*/ | ||
const E = { | ||
A: 1, | ||
B: 2, | ||
C: 3 | ||
}; | ||
|
||
exports.E = E; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this fix the 'enu' or 'enum' test (or both)?