Skip to content

Commit

Permalink
build: fix screenshot golden upload (#4128)
Browse files Browse the repository at this point in the history
* Fixes the Google Cloud Storage upload for the goldens.

The issue seems to happen because the `@google-cloud/storage` package has been installed manually and the `google-cloud` now uses a different storage version than before. Noticed this while debugging the `google-cloud` package.
  • Loading branch information
devversion authored and jelbourn committed Apr 18, 2017
1 parent e73af7d commit 008e1ab
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
"fs-extra": "^2.0.0",
"glob": "^7.1.1",
"google-closure-compiler": "^20170218.0.0",
"google-cloud": "^0.48.0",
"gulp": "^3.9.1",
"gulp-clean": "^0.3.2",
"gulp-clean-css": "^3.0.3",
Expand Down
4 changes: 2 additions & 2 deletions tools/gulp/util/firebase.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const firebaseAdmin = require('firebase-admin');
const firebase = require('firebase');
const gcloud = require('google-cloud');
const cloudStorage = require('@google-cloud/storage');

const config = require('../../../functions/config.json');

Expand All @@ -27,7 +27,7 @@ export function openFirebaseDashboardDatabase() {
* The files uploaded to google cloud are also available to firebase storage.
*/
export function openScreenshotsBucket() {
let gcs = gcloud.storage({
let gcs = cloudStorage({
projectId: 'material2-screenshots',
credentials: {
client_email: 'firebase-adminsdk-t4209@material2-screenshots.iam.gserviceaccount.com',
Expand Down

0 comments on commit 008e1ab

Please sign in to comment.