Skip to content

Commit

Permalink
build: fix benchpress build errors (#25121)
Browse files Browse the repository at this point in the history
Fixes the benchpress test build errors due to an old change
where the driver utilities have been moved.
  • Loading branch information
devversion authored Jun 21, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent fb09cf1 commit 8b5a632
Showing 22 changed files with 26 additions and 23 deletions.
4 changes: 2 additions & 2 deletions test/benchmarks/cdk/testing/component-harness/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ ts_library(
srcs = [":protractor-benchmark-utilities.ts"],
deps = [
":constants",
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//@types/node",
],
)
@@ -69,7 +69,7 @@ ng_test_library(
"//src/cdk/testing/testbed",
"//src/material/button",
"//src/material/button/testing",
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
],
)

Original file line number Diff line number Diff line change
@@ -106,7 +106,10 @@ describe('performance for the testbed harness environment', () => {
});
});

it('should fail intentionally so performance numbers are logged', fail);
// Enable this to see performance numbers in the console. Otherwise benchmark
// results are either put by benchpress into the runfile directory, or
// the `--test_output=streamed` Bazel flag should be used.
// it('should fail intentionally so performance numbers are logged', fail);
});

@Component({
2 changes: 1 addition & 1 deletion test/benchmarks/material/button/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":button.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/material/card/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":card.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/material/checkbox/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":checkbox.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/material/chips/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":chips.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/material/form-field/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":form-field.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/material/menu/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":menu.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/material/radio/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":radio.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/material/slide-toggle/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":slide-toggle.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/material/table/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ component_benchmark(
name = "benchmark",
driver = ":table.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/material/tabs/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":tabs.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/mdc/button/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":button.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/mdc/card/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":card.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/mdc/checkbox/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":checkbox.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/mdc/chips/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":chips.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/mdc/form-field/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":form-field.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/mdc/menu/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":menu.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/mdc/radio/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":radio.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/mdc/slide-toggle/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = ":slide-toggle.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/mdc/table/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ component_benchmark(
name = "benchmark",
driver = ":table.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],
2 changes: 1 addition & 1 deletion test/benchmarks/mdc/tabs/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ component_benchmark(
name = "benchmark",
driver = "tabs.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//@angular/dev-infra-private/bazel/benchmark/driver-utilities",
"@npm//protractor",
"@npm//@types/jasmine",
],

0 comments on commit 8b5a632

Please sign in to comment.