Skip to content

Commit

Permalink
Update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tinayuangao committed Feb 17, 2017
1 parent 8482fed commit b82a064
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion tools/gulp/task_helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,10 @@ export function isTravisPushBuild() {
return process.env['TRAVIS_PULL_REQUEST'] === 'false';
}

/** Open Google Cloud Storage for screenshots */
/**
* Open Google Cloud Storage for screenshots.
* The files uploaded to google cloud are also available to firebase storage.
*/
export function openScreenshotsBucket() {
let gcs = gcloud.storage({
projectId: 'material2-screenshots',
Expand Down
5 changes: 4 additions & 1 deletion tools/gulp/tasks/screenshots.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,10 @@ function diffScreenshot(filename: string, database: admin.database.Database,
}
}

/** Upload a list of filenames to firebase database as gold. */
/**
* Upload a list of filenames to firebase database as gold.
* This is necessary for control panel since google-cloud is not available to client side.
*/
function setScreenFilenames(database: admin.database.Database,
prNumber?: string) {
let filenames: string[] = getLocalScreenshotFiles(SCREENSHOT_DIR);
Expand Down

0 comments on commit b82a064

Please sign in to comment.